Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends the parametric aspects testing to include homeManager configuration, demonstrating that the parametric system works correctly with both NixOS and homeManager modules.
- Refactored
parametricStaticstoparametric.staticsin the library for better namespacing - Added homeManager test coverage to the parametric-with-owned test suite
- Modified the test module structure to support both NixOS and homeManager imports
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| templates/examples/modules/_example/ci/parametric-with-owned.nix | Adds homeManager configuration and test assertions to verify parametric aspects work with homeManager, including module imports, owned configuration, and package settings |
| nix/lib.nix | Refactors parametricStatics into parametric.statics for better namespacing, but contains a bug where the wrong parameter is passed to applyStatics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vic
force-pushed
the
parametric-hm
branch
2 times, most recently
from
668ad6d to
cce7c07
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vic
changed the title
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| homeManager = | ||
| { pkgs, ... }: | ||
| { | ||
| fwd.pkg = builtins.break pkgs.vim; |
There was a problem hiding this comment.
The builtins.break function is being used here, which will cause evaluation to stop. This appears to be a debugging artifact that should be removed. The line should be fwd.pkg = pkgs.vim; instead.
| fwd.pkg = builtins.break pkgs.vim; | |
| fwd.pkg = pkgs.vim; |
1 participant
See #99 (comment)
Fixes #99